New logical plan: Should not push up filter in front of Bincond
Review Request #544 - Created April 2, 2011 and submitted
The following script produce wrong result: data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray); best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip; filtered = FILTER best_url BY url == 'badsite.com'; dump filtered; data.txt: badsite.com 127.0.0.1 goodsite.com/1?foo=true goodsite.com 127.0.0.1 Expected: (badsite.com,127.0.0.1) We get nothing.
test-patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Unit test: all pass End-to-end test: all pass
Review request changed
Updated (April 4, 2011, 3:56 a.m.)
- changed from to branch-0.8