Review Board 1.7.22


Fix long paste of text in waves (WAVE-352)

Review Request #5256 - Created May 29, 2012 and submitted

Vicente J. Ruiz Jurado
Reviewers
wave
alown, michael.macfadden, yurize
wave
This patch addresses:
https://issues.apache.org/jira/browse/WAVE-352
adding a new configuration parameter, so we can configure and increase the size of messages in websocket.
The paste of a wikipedia article like:
http://en.wikipedia.org/wiki/Apache_Wave
in a wave now works without disconnections and data lost.
server-config.xml
Revision 5f39312 New Change
[20] 12 lines
[+20]
13
  <property name="signer_info_store_directory" value="_certificates" />
13
  <property name="signer_info_store_directory" value="_certificates" />
14
  <property name="attachment_store_directory" value="_attachments" />
14
  <property name="attachment_store_directory" value="_attachments" />
15
  <property name="account_store_directory" value="_accounts" />
15
  <property name="account_store_directory" value="_accounts" />
16
  <property name="delta_store_directory" value="_deltas" />
16
  <property name="delta_store_directory" value="_deltas" />
17
  <property name="sessions_store_directory" value="_sessions" />
17
  <property name="sessions_store_directory" value="_sessions" />

    
   
18
  <property name="websocket_max_message_size" value="2" />

    
   
19
  <property name="websocket_max_idle_time" value="0" />
18
  <property name="admin_user" value="@${wave_server_domain}" />
20
  <property name="admin_user" value="@${wave_server_domain}" />
19
  <property name="welcome_wave_id" value="" />
21
  <property name="welcome_wave_id" value="" />
20
  <property name="listener_executor_thread_count" value="1" />
22
  <property name="listener_executor_thread_count" value="1" />
21
  <property name="wavelet_load_executor_thread_count" value="1" />
23
  <property name="wavelet_load_executor_thread_count" value="1" />
22
  <property name="delta_persist_executor_thread_count" value="1" />
24
  <property name="delta_persist_executor_thread_count" value="1" />
[+20] [20] 59 lines
[+20]
82
                 value="${attachment_store_directory}" />
84
                 value="${attachment_store_directory}" />
83
          <token key="ACCOUNT_STORE_DIRECTORY"
85
          <token key="ACCOUNT_STORE_DIRECTORY"
84
                 value="${account_store_directory}" />
86
                 value="${account_store_directory}" />
85
          <token key="DELTA_STORE_DIRECTORY" value="${delta_store_directory}" />
87
          <token key="DELTA_STORE_DIRECTORY" value="${delta_store_directory}" />
86
          <token key="SESSIONS_STORE_DIRECTORY" value="${sessions_store_directory}" />
88
          <token key="SESSIONS_STORE_DIRECTORY" value="${sessions_store_directory}" />

    
   
89
          <token key="WEBSOCKET_MAX_MESSAGE_SIZE" value="${websocket_max_message_size}" />

    
   
90
          <token key="WEBSOCKET_MAX_IDLE_TIME" value="${websocket_max_idle_time}" />
87
          <token key="ADMIN_USER" value="${admin_user}" />
91
          <token key="ADMIN_USER" value="${admin_user}" />
88
          <token key="WELCOME_WAVE_ID" value="${welcome_wave_id}" />
92
          <token key="WELCOME_WAVE_ID" value="${welcome_wave_id}" />
89
          <token key="LISTENER_EXECUTOR_THREAD_COUNT" value="${listener_executor_thread_count}" />
93
          <token key="LISTENER_EXECUTOR_THREAD_COUNT" value="${listener_executor_thread_count}" />
90
          <token key="WAVELET_LOAD_EXECUTOR_THREAD_COUNT" value="${wavelet_load_executor_thread_count}" />
94
          <token key="WAVELET_LOAD_EXECUTOR_THREAD_COUNT" value="${wavelet_load_executor_thread_count}" />
91
          <token key="DELTA_PERSIST_EXECUTOR_THREAD_COUNT" value="${delta_persist_executor_thread_count}" />
95
          <token key="DELTA_PERSIST_EXECUTOR_THREAD_COUNT" value="${delta_persist_executor_thread_count}" />
[+20] [20] 45 lines
server.config.example
Revision 0d3da67 New Change
 
src/org/waveprotocol/box/server/CoreSettings.java
Revision d9b95ec New Change
 
src/org/waveprotocol/box/server/ServerModule.java
Revision a28faa2 New Change
 
src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java
Revision 65367c3 New Change
 
  1. server-config.xml: Loading...
  2. server.config.example: Loading...
  3. src/org/waveprotocol/box/server/CoreSettings.java: Loading...
  4. src/org/waveprotocol/box/server/ServerModule.java: Loading...
  5. src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java: Loading...