gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
Review Request #5085 - Created May 10, 2012 and submitted
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
Posted (May 10, 2012, 12:38 p.m.)
I am wondering if we want to try to not break backwards compatibility with this change. If there are gadgets out there that are passing VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think the chance of this is small, the code to support it is trivial. Comments in the code indicating why we look for both parameters would help too.