Review Board 1.7.22


gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig

Review Request #5085 - Created May 10, 2012 and submitted

Erik Bi
shindig-1772
Reviewers
shindig
ddumont, rbaxter, ssievers
shindig
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants. 
Update iotest.js
Review request changed
Updated (May 14, 2012, 12:39 p.m.)
Ship it!
Posted (May 14, 2012, 1:16 p.m.)
Erik every looks good, please attach the patch to the JIRA and I will commit this.
  1. Committed revision 1339144.  Please close the review.