Proposed fix for BZ 50903
Review Request #500 - Created March 13, 2011 and submitted
Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50903 Currently, if a connector is stopped with an open keep-alive connection, the next request received on that connection will be processed. This patch changes that so the request is not processed and the socket closed.
Includes unit test (executed with BIO) Manually tested with all 5 connectors.
Posted (March 14, 2011, 10:07 a.m.)
I think the entire solution is over complicated. Not a fan of introducing the processor into the input buffer, for an edge case. If you are stopping the connector, I would let the current request finish up. Since Tomcat 7 should bring the connection back to the endpoint in between keep alive requests, let the end point decide not to continue with the next request. I don't think modifying each input buffer to check if the end point is paused. Instead, I would delegate this responsibility to the endpoint to make the decision in between requests.