Review Board 1.7.22


HBASE-5676: Change append checks to sync and hflush checks.

Review Request #4999 - Created May 3, 2012 and updated

David Wang
0.96
HBASE-5676
Reviewers
hbase
hbase-git
Change append checks to sync and hflush checks, in keeping with the spirit of the original code.

Should only be applied to 0.96, as only 0.96 will support Hadoop 1.x+ according to HBASE-5536.
Passed local -PrunAllTests.  Passed test-patch.sh:


+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
Revision 6bc2cf2 New Change
[20] 22 lines
[+20]
23
Map<String, Integer> frags = null;
23
Map<String, Integer> frags = null;
24
ServerName rootLocation = null;
24
ServerName rootLocation = null;
25
ServerName metaLocation = null;
25
ServerName metaLocation = null;
26
List<ServerName> servers = null;
26
List<ServerName> servers = null;
27
Set<ServerName> deadServers = null;
27
Set<ServerName> deadServers = null;
28
boolean showAppendWarning = false;
28
boolean showSyncWarning = false;

    
   
29
boolean showHflushWarning = false;
29
String filter = "general";
30
String filter = "general";
30
String format = "html";
31
String format = "html";
31
</%args>
32
</%args>
32
<%import>
33
<%import>
33
java.util.*;
34
java.util.*;
[+20] [20] 45 lines
[+20]
79
  unstable with HBase. Please see the
80
  unstable with HBase. Please see the
80
  <a href="http://wiki.apache.org/hadoop/Hbase/Troubleshooting#A18">HBase wiki</a>
81
  <a href="http://wiki.apache.org/hadoop/Hbase/Troubleshooting#A18">HBase wiki</a>
81
  for details.
82
  for details.
82
  </div>
83
  </div>
83
</%if>
84
</%if>
84
<%if showAppendWarning %> 
85
<%if showSyncWarning && showHflushWarning %>
85
  <div class="warning">
86
  <div class="warning">
86
  You are currently running the HMaster without HDFS append support enabled.
87
  You are currently running the HMaster without either HDFS sync or hflush support enabled.
87
  This may result in data loss.
88
  This may result in data loss.
88
  Please see the <a href="http://wiki.apache.org/hadoop/Hbase/HdfsSyncSupport">HBase wiki</a>
89
  Please see the <a href="http://wiki.apache.org/hadoop/Hbase/HdfsSyncSupport">HBase wiki</a>
89
  for details.
90
  for details.
90
  </div>
91
  </div>
91
</%if>
92
</%if>
[+20] [20] 164 lines
src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java
Revision a0aaaf4 New Change
 
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java
Revision 302a3b1 New Change
 
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
Revision 3d35d3e New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
Revision 3ea0a3b New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
Revision cb7efc3 New Change
 
src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Revision 339a120 New Change
 
  1. src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon: Loading...
  2. src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java: Loading...
  3. src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java: Loading...
  4. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java: Loading...
  5. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java: Loading...
  6. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java: Loading...
  7. src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java: Loading...