Review Board 1.7.22


HBASE-5676: Change append checks to sync and hflush checks.

Review Request #4999 - Created May 3, 2012 and updated

David Wang
0.96
HBASE-5676
Reviewers
hbase
hbase-git
Change append checks to sync and hflush checks, in keeping with the spirit of the original code.

Should only be applied to 0.96, as only 0.96 will support Hadoop 1.x+ according to HBASE-5536.
Passed local -PrunAllTests.  Passed test-patch.sh:


+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.
Posted (May 3, 2012, 9:48 p.m.)
Are you sure this is right? If you're using HBase against Hadoop 1.0, for example, the syncFs() call exists, but sync isn't enabled by default, so this would give you an incorrect result, I'd think