Review Board 1.7.22


HBASE-5889 Remove HRegionInterface

Review Request #4993 - Created May 3, 2012 and submitted

Jimmy Xiang
trunk
HBASE-5889
Reviewers
hbase
hbase-git
Removed HRegionInterface, and cleaned up the HRegionServer, moved pb code from RegionServer back to HRegionServer.

The goal is to avoid two copies of region server code to maintain, and make it possible to avoid data type conversion in the sever side.

Fixed some unit tests.  Now all region server unit tests test the new pb functions.

Enhanced getServerInfo so that it returns the webui port too.
All regular and security profile tests are green before I rebased to the latest today.

Diff revision 3 (Latest)

1 2 3
1 2 3

  1. conf/hbase-policy.xml: Loading...
  2. security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java: Loading...
  3. src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon: Loading...
  4. src/main/java/org/apache/hadoop/hbase/HConstants.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: Loading...
  6. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java: Loading...
  7. src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java: Loading...
  8. src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java: Loading...
  9. src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java: Loading...
  10. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: Loading...
  11. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java: Loading...
  12. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java: Loading...
  13. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java: Loading...
  14. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java: Loading...
  15. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java: Loading...
  16. src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java: Loading...
  17. src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java: Loading...
  18. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java: Loading...
  19. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: Loading...
  20. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java: Loading...
This diff has been split across 2 pages: 1 2 >
conf/hbase-policy.xml
Revision e45f23c New Change
1
<?xml version="1.0"?>
1
<?xml version="1.0"?>
2
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
2
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
3
<!--
3
<!--
4
/**
4
/**
5
 * Licensed to the Apache Software Foundation (ASF) under one
5
 * Licensed to the Apache Software Foundation (ASF) under one
6
 * or more contributor license agreements.  See the NOTICE file
6
 * or more contributor license agreements.  See the NOTICE file
7
 * distributed with this work for additional information
7
 * distributed with this work for additional information
8
 * regarding copyright ownership.  The ASF licenses this file
8
 * regarding copyright ownership.  The ASF licenses this file
9
 * to you under the Apache License, Version 2.0 (the
9
 * to you under the Apache License, Version 2.0 (the
10
 * "License"); you may not use this file except in compliance
10
 * "License"); you may not use this file except in compliance
11
 * with the License.  You may obtain a copy of the License at
11
 * with the License.  You may obtain a copy of the License at
12
 *
12
 *
13
 *     http://www.apache.org/licenses/LICENSE-2.0
13
 *     http://www.apache.org/licenses/LICENSE-2.0
14
 *
14
 *
15
 * Unless required by applicable law or agreed to in writing, software
15
 * Unless required by applicable law or agreed to in writing, software
16
 * distributed under the License is distributed on an "AS IS" BASIS,
16
 * distributed under the License is distributed on an "AS IS" BASIS,
17
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
18
 * See the License for the specific language governing permissions and
18
 * See the License for the specific language governing permissions and
19
 * limitations under the License.
19
 * limitations under the License.
20
 */
20
 */
21
-->
21
-->
22

    
   
22

   
23
<configuration>
23
<configuration>
24
  <property>
24
  <property>
25
    <name>security.client.protocol.acl</name>
25
    <name>security.client.protocol.acl</name>
26
    <value>*</value>
26
    <value>*</value>
27
    <description>ACL for HRegionInterface protocol implementations (ie. 
27
    <description>ACL for ClientProtocol and AdminProtocol implementations (ie. 
28
    clients talking to HRegionServers)
28
    clients talking to HRegionServers)
29
    The ACL is a comma-separated list of user and group names. The user and 
29
    The ACL is a comma-separated list of user and group names. The user and 
30
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
30
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
31
    A special value of "*" means all users are allowed.</description>
31
    A special value of "*" means all users are allowed.</description>
32
  </property>
32
  </property>
33

    
   
33

   
34
  <property>
34
  <property>
35
    <name>security.admin.protocol.acl</name>
35
    <name>security.admin.protocol.acl</name>
36
    <value>*</value>
36
    <value>*</value>
37
    <description>ACL for HMasterInterface protocol implementation (ie. 
37
    <description>ACL for HMasterInterface protocol implementation (ie. 
38
    clients talking to HMaster for admin operations).
38
    clients talking to HMaster for admin operations).
39
    The ACL is a comma-separated list of user and group names. The user and 
39
    The ACL is a comma-separated list of user and group names. The user and 
40
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
40
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
41
    A special value of "*" means all users are allowed.</description>
41
    A special value of "*" means all users are allowed.</description>
42
  </property>
42
  </property>
43

    
   
43

   
44
  <property>
44
  <property>
45
    <name>security.masterregion.protocol.acl</name>
45
    <name>security.masterregion.protocol.acl</name>
46
    <value>*</value>
46
    <value>*</value>
47
    <description>ACL for HMasterRegionInterface protocol implementations
47
    <description>ACL for HMasterRegionInterface protocol implementations
48
    (for HRegionServers communicating with HMaster)
48
    (for HRegionServers communicating with HMaster)
49
    The ACL is a comma-separated list of user and group names. The user and 
49
    The ACL is a comma-separated list of user and group names. The user and 
50
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
50
    group list is separated by a blank. For e.g. "alice,bob users,wheel". 
51
    A special value of "*" means all users are allowed.</description>
51
    A special value of "*" means all users are allowed.</description>
52
  </property>
52
  </property>
53
</configuration>
53
</configuration>
security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
Revision fda40cc New Change
 
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
Revision 87f04f4 New Change
 
src/main/java/org/apache/hadoop/hbase/HConstants.java
Revision a9d80a0 New Change
 
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
Revision e3912c2 New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
Revision fc9176d New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
Revision 757f98e New Change
 
src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
Revision cd9b528 New Change
 
src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
Revision 79d5fdd New Change
 
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
Revision 6ba8ab0 New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
Revision 212ee3e New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
Revision d1e0993 New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
Revision 81603af New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
Revision fbf0127 New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
Revision db1333b New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
Revision ae2094d New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
Revision 8b45f03 New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
Revision 827fb23 New Change
 
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Revision 8c8381b New Change
 
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
Revision 4cb070e New Change
 
  1. conf/hbase-policy.xml: Loading...
  2. security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java: Loading...
  3. src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon: Loading...
  4. src/main/java/org/apache/hadoop/hbase/HConstants.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: Loading...
  6. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java: Loading...
  7. src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java: Loading...
  8. src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java: Loading...
  9. src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java: Loading...
  10. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: Loading...
  11. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java: Loading...
  12. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java: Loading...
  13. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java: Loading...
  14. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java: Loading...
  15. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java: Loading...
  16. src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java: Loading...
  17. src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java: Loading...
  18. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java: Loading...
  19. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: Loading...
  20. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java: Loading...
This diff has been split across 2 pages: 1 2 >