Review Board 1.7.22


HBASE-5889 Remove HRegionInterface

Review Request #4993 - Created May 3, 2012 and submitted

Jimmy Xiang
trunk
HBASE-5889
Reviewers
hbase
hbase-git
Removed HRegionInterface, and cleaned up the HRegionServer, moved pb code from RegionServer back to HRegionServer.

The goal is to avoid two copies of region server code to maintain, and make it possible to avoid data type conversion in the sever side.

Fixed some unit tests.  Now all region server unit tests test the new pb functions.

Enhanced getServerInfo so that it returns the webui port too.
All regular and security profile tests are green before I rebased to the latest today.

Diff revision 1

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

1 2 3
1 2 3

  1. src/main/protobuf/Admin.proto: Loading...
  2. src/main/protobuf/RPC.proto: Loading...
  3. src/main/resources/hbase-default.xml: Loading...
  4. src/main/resources/hbase-webapps/master/table.jsp: Loading...
  5. src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java: Loading...
  6. src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java: Loading...
  7. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java: Loading...
  8. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java: Loading...
  9. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java: Loading...
  10. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java: Loading...
  11. src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java: Loading...
  12. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java: Loading...
  13. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java: Loading...
  14. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java: Loading...
  15. src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java: Loading...
  16. src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java: Loading...
  17. src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java: Loading...
  18. src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java: Loading...
  19. src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java: Loading...
  20. src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java: Loading...
  21. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java: Loading...
  22. src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java: Loading...
  23. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java: Loading...
  24. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java: Loading...
This diff has been split across 2 pages: < 1 2
src/main/protobuf/Admin.proto
Revision 2ad6fb0 New Change
[20] 171 lines
[+20]
172
}
172
}
173

    
   
173

   
174
message ReplicateWALEntryResponse {
174
message ReplicateWALEntryResponse {
175
}
175
}
176

    
   
176

   
177
// Replacement for rollHLogWriter in HRegionInterface 

   
178
message RollWALWriterRequest {
177
message RollWALWriterRequest {
179
}
178
}
180

    
   
179

   
181
message RollWALWriterResponse {
180
message RollWALWriterResponse {
182
  // A list of encoded name of regions to flush
181
  // A list of encoded name of regions to flush
[+20] [20] 8 lines
[+20]
191
}
190
}
192

    
   
191

   
193
message GetServerInfoRequest {
192
message GetServerInfoRequest {
194
}
193
}
195

    
   
194

   
196
message GetServerInfoResponse {
195
message ServerInfo {
197
  required ServerName serverName = 1;
196
  required ServerName serverName = 1;

    
   
197
  optional uint32 webuiPort = 2;

    
   
198
}

    
   
199

   

    
   
200
message GetServerInfoResponse {

    
   
201
  required ServerInfo serverInfo = 1;
198
}
202
}
199

    
   
203

   
200
service AdminService {
204
service AdminService {
201
  rpc getRegionInfo(GetRegionInfoRequest)
205
  rpc getRegionInfo(GetRegionInfoRequest)
202
    returns(GetRegionInfoResponse);
206
    returns(GetRegionInfoResponse);
[+20] [20] 34 lines
src/main/protobuf/RPC.proto
Revision 105fb3f New Change
 
src/main/resources/hbase-default.xml
Revision f54b345 New Change
 
src/main/resources/hbase-webapps/master/table.jsp
Revision ca7310c New Change
 
src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
Revision a1992c3 New Change
 
src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java
Revision ad77e0a New Change
 
src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
Revision 5574b7f New Change
 
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
Revision 3dfc94e New Change
 
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
Revision 42092b7 New Change
 
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
Revision c270e28 New Change
 
src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
Revision c36272f New Change
 
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
Revision bdec3ee New Change
 
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
Revision 7dbba66 New Change
 
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
Revision 3acb988 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
Revision eb546a5 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
Revision ceba5cd New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
Revision ec08b17 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java
Revision 30c6cf1 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
Revision 8c3f67e New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
Revision 7bfe4cd New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
Revision ffce7e8 New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
Revision aa5ca37 New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
Revision 65fa948 New Change
 
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
Revision fc4a0a7 New Change
 
  1. src/main/protobuf/Admin.proto: Loading...
  2. src/main/protobuf/RPC.proto: Loading...
  3. src/main/resources/hbase-default.xml: Loading...
  4. src/main/resources/hbase-webapps/master/table.jsp: Loading...
  5. src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java: Loading...
  6. src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java: Loading...
  7. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java: Loading...
  8. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java: Loading...
  9. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java: Loading...
  10. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java: Loading...
  11. src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java: Loading...
  12. src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java: Loading...
  13. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java: Loading...
  14. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java: Loading...
  15. src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java: Loading...
  16. src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java: Loading...
  17. src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java: Loading...
  18. src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java: Loading...
  19. src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java: Loading...
  20. src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java: Loading...
  21. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java: Loading...
  22. src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java: Loading...
  23. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java: Loading...
  24. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java: Loading...
This diff has been split across 2 pages: < 1 2