Review Board 1.7.22


HBASE-5889 Remove HRegionInterface

Review Request #4993 - Created May 3, 2012 and submitted

Jimmy Xiang
trunk
HBASE-5889
Reviewers
hbase
hbase-git
Removed HRegionInterface, and cleaned up the HRegionServer, moved pb code from RegionServer back to HRegionServer.

The goal is to avoid two copies of region server code to maintain, and make it possible to avoid data type conversion in the sever side.

Fixed some unit tests.  Now all region server unit tests test the new pb functions.

Enhanced getServerInfo so that it returns the webui port too.
All regular and security profile tests are green before I rebased to the latest today.
security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
Diff Revision 1 Diff Revision 3
[20] 18 lines
[+20]
19

    
   
19

   
20
import org.apache.hadoop.conf.Configuration;
20
import org.apache.hadoop.conf.Configuration;
21
import org.apache.hadoop.hbase.client.AdminProtocol;
21
import org.apache.hadoop.hbase.client.AdminProtocol;
22
import org.apache.hadoop.hbase.client.ClientProtocol;
22
import org.apache.hadoop.hbase.client.ClientProtocol;
23
import org.apache.hadoop.hbase.ipc.HMasterInterface;
23
import org.apache.hadoop.hbase.ipc.HMasterInterface;
24
import org.apache.hadoop.hbase.ipc.HMasterRegionInterface;
24
import org.apache.hadoop.hbase.ipc.RegionServerStatusProtocol;
25
import org.apache.hadoop.security.authorize.PolicyProvider;
25
import org.apache.hadoop.security.authorize.PolicyProvider;
26
import org.apache.hadoop.security.authorize.Service;
26
import org.apache.hadoop.security.authorize.Service;
27
import org.apache.hadoop.security.authorize.ServiceAuthorizationManager;
27
import org.apache.hadoop.security.authorize.ServiceAuthorizationManager;
28

    
   
28

   
29
/**
29
/**
30
 * Implementation of secure Hadoop policy provider for mapping
30
 * Implementation of secure Hadoop policy provider for mapping
31
 * protocol interfaces to hbase-policy.xml entries.
31
 * protocol interfaces to hbase-policy.xml entries.
32
 */
32
 */
33
public class HBasePolicyProvider extends PolicyProvider {
33
public class HBasePolicyProvider extends PolicyProvider {
34
  protected static Service[] services = {
34
  protected static Service[] services = {
35
      new Service("security.client.protocol.acl", ClientProtocol.class),
35
      new Service("security.client.protocol.acl", ClientProtocol.class),
36
      new Service("security.client.protocol.acl", AdminProtocol.class),
36
      new Service("security.client.protocol.acl", AdminProtocol.class),
37
      new Service("security.admin.protocol.acl", HMasterInterface.class),
37
      new Service("security.admin.protocol.acl", HMasterInterface.class),
38
      new Service("security.masterregion.protocol.acl", HMasterRegionInterface.class)
38
      new Service("security.masterregion.protocol.acl", RegionServerStatusProtocol.class)
39
  };
39
  };
40

    
   
40

   
41
  @Override
41
  @Override
42
  public Service[] getServices() {
42
  public Service[] getServices() {
43
    return services;
43
    return services;
[+20] [20] 12 lines
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
Diff Revision 1 Diff Revision 3
 
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
Diff Revision 1 Diff Revision 3
 
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
Diff Revision 1 Diff Revision 3
 
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Diff Revision 1 Diff Revision 3
 
src/main/resources/hbase-webapps/master/table.jsp
Diff Revision 1 Diff Revision 3 - File Reverted
 
  1. security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java: Loading...
  2. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java: Loading...
  3. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: Loading...
  4. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: Loading...
  6. src/main/resources/hbase-webapps/master/table.jsp: Loading...