Review Board 1.7.22


Crawler command line bugs

Review Request #4989 - Created May 3, 2012 and updated

Thomas Bennett
OODT-454
Reviewers
oodt
bfoster, mattmann, pramirez, sherylj
oodt
1) In handleOption(), test for multiple options and handle appropriately.

2) Set the value for Unique.filemgrUlr in filemgrUrl bean.

3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be TriggerPostIngestWorkflow.workflowMgrUrl

 
Posted (May 4, 2012, 4:24 p.m.)

   

  
Interesting, so this has to be expanded out -- was this because of the Spring API here and the way that you set these types of properties?
Hey Tom, nothing to do with you here, but (maybe for bfost) -- why did this action name change to TriggerPostIngestWorkflow?
Ship it!
Posted (May 4, 2012, 4:24 p.m.)
LGTM.
Posted (May 7, 2012, 8:50 p.m.)

   

  
is your crawler synced?... this is what the trunk handleOption() method looks like right now:

   @Override
   public void handleOption(CmdLineAction selectedAction,
         CmdLineOptionInstance optionInstance) {
      for (String beanProperty : properties) {
         if (optionInstance.getValues().size() > 1) {
            for (int i = 0; i < optionInstance.getValues().size(); i++) {
               ActionBeanProperties.setProperty(beanProperty + "[" + i + "]",
                     optionInstance.getValues().get(i));
            }
         } else if (!optionInstance.getValues().isEmpty()) {
            ActionBeanProperties.setProperty(beanProperty,
                  optionInstance.getValues().get(0));
         } else {
            throw new RuntimeException(
                  CrawlerBeansPropHandler.class.getCanonicalName()
                        + " can't apply option '" + optionInstance.getOption()
                        + "' since it has no value");
         }
      }
   }
good catch... think you've got a spelling error here though: Ulr should be Url
good catch... i renamed this cause the original name didn't really make sense