Review Board 1.7.22


Refactor common navbar into header.tag

Review Request #4930 - Created April 29, 2012 and submitted

Chris Geer
RAVE-586
Reviewers
rave
rave
Refactored the common navbar components to the header.tag file and included that in all relevant jsp files (except mobile). I also expanded the NavigationItem code to handle parameters for the navigation item text. Moved menu generation code to the ControllerUtils class. This should eventually be loaded from a DB per ticket RAVE-589
Went through all screens to verify items showed as expected and had the correct links.
Review request changed
Updated (May 3, 2012, 5:40 p.m.)
Made changes based on Matt's comments.
Ship it!
Posted (May 3, 2012, 7:02 p.m.)
LGTM
  1. Thanks Matt. I forward to seeing it committed. I'll start thinking about the next steps.
Ship it!
Posted (May 3, 2012, 9:33 p.m.)
LGTM - I will apply.