Review Board 1.7.22


FLUME-1160: Removing NPE catch clause.

Review Request #4927 - Created April 28, 2012 and submitted

Hari Shreedharan
trunk
FLUME-1160
Reviewers
Flume
brocknoland
flume-git
Actually nothing in that try block would throw an NPE, so removing it. To clarify: 
* a check for type being null is done before entering this code. 
* valueOf throws an IllegalArgumentException if the type cannot be found(which is caught and rethrown)
* All of the getConfiguration functions *will* return a configuration object(or throw) and not return null.

 
Review request changed
Updated (April 28, 2012, 9:36 p.m.)
  • Actually nothing in that try block would throw an NPE, so removing it. 

    Actually nothing in that try block would throw an NPE, so removing it. To clarify: 
    * a check for type being null is done before entering this code. 
    * valueOf throws an IllegalArgumentException if the type cannot be found(which is caught and rethrown)
    * All of the getConfiguration functions *will* return a configuration object(or throw) and not return null.
Update description.
Ship it!
Posted (April 28, 2012, 11:27 p.m.)
lgtm, attache the patch to the jira if not already there
  1. Thanks Brock! Already attached.