Review Board 1.7.22


Add lang and country substitution for ifr in client side

Review Request #4906 - Created April 27, 2012 and submitted

qiaoyun sun
SHINDIG-1763
Reviewers
shindig
ddumont, rbaxter, ssievers
shindig
If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
For example: the ifr is like :
http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0

They should be substituted by the browser's setting in client side. 

 
Review request changed
Updated (May 10, 2012, 6:49 a.m.)
change the corresponding js unit test
Ship it!
Posted (May 10, 2012, 11:30 a.m.)

   

  
Small nit on trailing whitespace.
Ship it!
Posted (May 10, 2012, 12:52 p.m.)
LGTM.  I removed the whitespace for you.  Please close the review.
Committed revision 1336646