Review Board 1.7.22

FLUME-1131: ChannelProcessor does not handle transactions appropriately

Review Request #4837 - Created April 22, 2012 and updated

Brock Noland
ChannelProcessor did not handle transactions well, in some cases if anything but ChannelException was thrown, the close in the finally would throw an exception as rollback was not called. In other cases if a subclass of error was thrown the same would occurred. Additionally, if getTransaction threw an exception the null transaction value was not handled and an NPE would be thrown.
Tests added and tests pass.
Review request changed
Updated (May 5, 2012, 3:44 p.m.)
Updated patch which addresses the review items.