Review Board 1.7.22


Set identification on HttpRequests

Review Request #4750 - Created April 17, 2012 and submitted

BrianLillie
SHINDIG-1756
Reviewers
shindig
shindig
Update HttpRequest objects to identify a request source.  For some requests, SecurityTokens are provided.   Others have gadget URI, but this is not always trustworthy as it is set based upon URL parameters.
For requests where a security token was not sent from the client, create and set an AnonymousSecurityToken identifying the gadget URI associated with the request.   Also, add a flag to the HttpRequest to indicate a request generated by the server, where this may be set when requesting services, retrieving a template library, or during selected rewrites.
Existing tests passed.  Added additional tests to verify internal request state or token on requests.
Review request changed
Updated (April 26, 2012, 1:10 p.m.)
Fixed the nits on the braces.
Ship it!
Posted (April 26, 2012, 8:56 p.m.)
Committed revision 1331083.  Thanks Brian!