Review Board 1.7.22


HBASE-5621 Convert admin protocol of HRegionInterface to PB

Review Request #4714 - Created April 13, 2012 and submitted

Jimmy Xiang
trunk
HBASE-5621
Reviewers
hbase
hbase-git
This is the admin part of HBase-5443.  AdminProtocol part.
All unit tests passed.
Review request changed
Updated (April 19, 2012, 5:46 p.m.)
Rebased to the latest of the trunk.
Posted (April 19, 2012, 8:43 p.m.)

   

  
  1. I did a rebase. So it picked up some other changes if you diff 2 from 3.
There are a bunch of import changes here.  Are they all needed?
  1. It must be from other patch.  This patch doesn't touch this file.
Why can we get away w/ removing the try/catch?  Because the caller handles it?
  1. That change in diff2 is already checked in as part of 5443 addendum.  That's why it shows some change here.  This patch doesn't change this file.
good
Does this belong in this patch?  Is it part of another patch?
  1. From another patch due to rebasing.
Yeah, this stuff is from another patch?  Why you adding it?
  1. From another patch due to rebasing.
Are these from Elliotts' patch?

Maybe its reviewboard that is messing up?  I'm only looking at diff between your v2 and v3 patch.
  1. From another patch due to rebasing.
Ship it!
Posted (April 19, 2012, 11:40 p.m.)
I'm good w/ this patch.  Good stuff Jimmy
Please file an issue to address this recursion (an AdminProtocol 'has' a HConnection but you get the AdminProtocol from an HConnection).
This is a noop