Review Board 1.7.22


Need to support query parameter for Social REST API (continue li's patch).

Review Request #4680 - Created April 9, 2012 and submitted

Yao Zhang
SHINDIG-1698
Reviewers
shindig
rbaxter, ssievers, woodstae
shindig
This is the patch for https://reviews.apache.org/r/3764 as xuli is not working on it.
@Ryan, I have merged line 58 and 59 of /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java and break line 60 into multiple lines. As predefinedParameters is using RequestItem, it can not be changed to private static final.
done
Review request changed
Updated (April 12, 2012, 1:47 a.m.)
Hi Ryan, test case is added. Please review.
Ship it!
Posted (April 12, 2012, 12:09 p.m.)
LGTM, have you signed up for Apache/s JIRA deployment?  I want to assign the JIRA to you and have you upload the final patch to the JIRA granting the ASF license before I submit the code.  I tried to look for you to assign the JIRA to you but I didn't see you in the JIRA system.  If you have not registered could you?

https://issues.apache.org/jira/browse/SHINDIG
  1. Hi Ryan,
    
    My username is yaozhang. I have upload the patch to https://issues.apache.org/jira/browse/SHINDIG-1698 and grant the ASF license.
  2. Committed please close the review.  Thanks.