Review Board 1.7.22


FLUME-1108: FILE_ROLL sink doesn't accept value 0 for unlimited wait time before rolling file

Review Request #4672 - Created April 6, 2012 and submitted

Hari Shreedharan
trunk
FLUME-1108
Reviewers
Flume
flume-git
If rollInterval is set to 0, RollingFileSink does not roll file.
Added unit test.
Ship it!
Posted (April 6, 2012, 9:24 p.m.)
hmm .. disable rolling for for a component called 'rolling file sink', that's like ordering Ice tea with no ice ;) This probably not be useful in a real production cases, but certainly very handy for testing/validating.

Changes look fine to me. 
Ship it!
Posted (April 7, 2012, 12:45 p.m.)
LGTM!
Yes, I think it would be useful especially in testing scenario. This can be considered the degenerate case, and doesn't affect existing functionality. It's consistent with semantics for other sources/sinks where "0" value is specified. Saves user from needing to enter a high value for rolloverInterval when running multi-day endurance tests.