Review Board 1.7.22


PIG-2167 - Naive implementation of CUBE operator

Review Request #4670 - Created April 6, 2012 and updated

Prasanth_J
PIG-2167
Reviewers
pig
dvryaboy
pig
This is a review board for https://issues.apache.org/jira/browse/PIG-2167
Unit tests: All passed

Pre-commit tests: All passed
ant clean test-commit

Changes between revision 1 and 2

1 2 3
1 2 3

  1. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/AllExpressionVisitor.java: Loading...
  2. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/SchemaResetter.java: Loading...
  3. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOCube.java: Loading...
  4. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LogicalRelationalNodesVisitor.java: Loading...
  5. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ProjectStarExpander.java: Loading...
  6. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g: Loading...
  7. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstPrinter.g: Loading...
  8. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstValidator.g: Loading...
  9. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java: Loading...
  10. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanGenerator.g: Loading...
  11. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryLexer.g: Loading...
  12. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParser.g: Loading...
  13. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLexer.pig: Loading...
  14. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java: Loading...
  15. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestParser.pig: Loading...
  16. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryLexer.java: Loading...
  17. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryParser.java: Loading...
  18. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestCubeOperator.java: Loading...
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/AllExpressionVisitor.java
Diff Revision 1 Diff Revision 2
This file contains only whitespace changes.
[20] 92 lines
[+20] [+] public void visit(LOJoin join) throws FrontendException {
93
    
93
    
94
    @Override
94
    @Override
95
    public void visit(LOCube cu) throws FrontendException {
95
    public void visit(LOCube cu) throws FrontendException {
96
        currentOp = cu;
96
	currentOp = cu;
97
        MultiMap<Integer, LogicalExpressionPlan> expressionPlans = cu.getExpressionPlans();
97
	MultiMap<Integer, LogicalExpressionPlan> expressionPlans = cu.getExpressionPlans();
98
        for( Integer key : expressionPlans.keySet() ) {
98
	for (Integer key : expressionPlans.keySet()) {
99
            Collection<LogicalExpressionPlan> exprPlans = expressionPlans.get(key);
99
	    Collection<LogicalExpressionPlan> exprPlans = expressionPlans.get(key);
100
            for( LogicalExpressionPlan plan : exprPlans ) {
100
	    for (LogicalExpressionPlan plan : exprPlans) {
101
                LogicalExpressionVisitor v = getVisitor(plan);
101
		LogicalExpressionVisitor v = getVisitor(plan);
102
                v.visit();
102
		v.visit();
103
            }
103
	    }
104
        }
104
	}
105
    }
105
    }
[+20] [20] 64 lines
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/SchemaResetter.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOCube.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LogicalRelationalNodesVisitor.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ProjectStarExpander.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstPrinter.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstValidator.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanGenerator.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryLexer.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParser.g
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLexer.pig
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestParser.pig
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryLexer.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryParser.java
Diff Revision 1 Diff Revision 2
 
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestCubeOperator.java
Diff Revision 1 Diff Revision 2
 
  1. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/AllExpressionVisitor.java: Loading...
  2. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/optimizer/SchemaResetter.java: Loading...
  3. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOCube.java: Loading...
  4. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LogicalRelationalNodesVisitor.java: Loading...
  5. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ProjectStarExpander.java: Loading...
  6. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g: Loading...
  7. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstPrinter.g: Loading...
  8. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AstValidator.g: Loading...
  9. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java: Loading...
  10. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanGenerator.g: Loading...
  11. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryLexer.g: Loading...
  12. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParser.g: Loading...
  13. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLexer.pig: Loading...
  14. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestLogicalPlanGenerator.java: Loading...
  15. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestParser.pig: Loading...
  16. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryLexer.java: Loading...
  17. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestQueryParser.java: Loading...
  18. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestCubeOperator.java: Loading...