Review Board 1.7.22


Channel selector config

Review Request #4514 - Created March 27, 2012 and updated

Hari Shreedharan
trunk
FLUME-1064
Reviewers
Flume
flume-git
Channel selector config

 
Review request changed
Updated (April 24, 2012, 4:22 a.m.)
  • Multiplexing channel selector config

    Channel selector config
  • changed from Multiplexing channel selector config to Channel selector config
Posted (May 9, 2012, 8:48 a.m.)
Looks good to me.

It doesn't seem to patch correctly against the trunk, so  if you could rebase it, that would help.

While not relevant to this issue, the configuration for this should really be documented, we can't expect end users to  trawl the code to figure it out

If you can  fix these niggles when you rebase it, shoud be good to go
Changing the name immutableMap to something more descriptive would help legibility
weird indentation(this should be ending the function... looks like refactoring tools used the wrong closing bracket