Review Board 1.7.22


RAVE526. Support height attribute of open social gadget definition

Review Request #4468 - Created March 23, 2012 and updated

Dennis Laan, van der
RAVE-526
Reviewers
rave
rave
An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well. 
Tested on gadgets: 
- without height attribute and without dynamic height, 
- without height and with dynamic height, 
- with height and without dynamic height,
- with height and with dynamic height

Diff revision 2 (Latest)

1 2
1 2

  1. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js: Loading...
Content-Type: text/html; charset=utf-8
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
Revision 1295528 New Change
Diff currently unavailable.
Error: The file '/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js' (r1295528) could not be found in the repository: '/repos/asf/!svn/bc/1295528/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js' path not found
Details
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/views.py", line 117, in view_diff
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 344, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 137, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 136, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 141, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 126, in get_original_file
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 192, in get_file
    large_data=True)[0]
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 191, in <lambda>
    request)],
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 287, in _get_file_uncached
    data = self.get_scmtool().get_file(path, revision)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/svn.py", line 191, in get_file
    return self._do_on_path(get_file_data, path, revision)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/svn.py", line 165, in _do_on_path
    raise FileNotFoundError(path, revision, detail=str(e))
FileNotFoundError: The file '/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js' (r1295528) could not be found in the repository: '/repos/asf/!svn/bc/1295528/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js' path not found
  1. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js: Loading...