Review Board 1.7.22


HBASE-5444: Add PB-based calls to HMasterRegionInterface

Review Request #4463 - Created March 23, 2012 and updated

Gregory Chanan
0.96
HBASE-5444
Reviewers
hbase
stack
hbase-git
Adds PB-based calls replacing HMasterRegionInterface.

There are some temporary hacks, e.g. converting PB-based ServerLoad to existing HServerLoad so I didn't need to convert ClusterStatus (which brings in a lot of other changes).  That will be cleaned up in HBASE-5445.
Ran jenkins job, all unit tests passed.

Diff revision 1

This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.

1 2 3 4 5
1 2 3 4 5

  1. pom.xml: Loading...
  2. src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon: Loading...
  3. src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon: Loading...
  4. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/HConstants.java: Loading...
  6. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java: Loading...
  7. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java: Loading...
  8. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java: Loading...
  9. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java: Loading...
  10. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java: Loading...
  11. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java: Loading...
  12. src/main/java/org/apache/hadoop/hbase/master/HMaster.java: Loading...
  13. src/main/java/org/apache/hadoop/hbase/master/MXBean.java: Loading...
  14. src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java: Loading...
  15. src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java: Loading...
  16. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: Loading...
  17. src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java: Loading...
  18. src/main/java/org/apache/hadoop/hbase/protobuf/PBHelper.java: Loading...
  19. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: Loading...
  20. src/main/proto/MasterRegionProtocol.proto: Loading...
  21. src/main/proto/hbase.proto: Loading...
  22. src/main/resources/hbase-webapps/master/table.jsp: Loading...
  23. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java: Loading...
  24. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java: Loading...
  25. src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java: Loading...
  26. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java: Loading...
  27. src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java: Loading...
  28. src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java: Loading...
pom.xml
Revision 10b13ef New Change
[20] 762 lines
[+20]
763
      <plugin>
763
      <plugin>
764
        <artifactId>maven-antrun-plugin</artifactId>
764
        <artifactId>maven-antrun-plugin</artifactId>
765
        <version>1.6</version>
765
        <version>1.6</version>
766
        <executions>
766
        <executions>
767
          <execution>
767
          <execution>

    
   
768
            <id>compile-proto</id>

    
   
769
            <phase>generate-sources</phase>

    
   
770
            <goals>

    
   
771
              <goal>run</goal>

    
   
772
            </goals>

    
   
773
            <configuration>

    
   
774
              <target>

    
   
775
                <echo file="target/compile-proto.sh">

    
   
776
                    PROTO_DIR=src/main/proto

    
   
777
                    JAVA_DIR=target/generated-sources/java

    
   
778
                    which cygpath 2> /dev/null

    
   
779
                    if [ $? = 1 ]; then

    
   
780
                      IS_WIN=false

    
   
781
                    else

    
   
782
                      IS_WIN=true

    
   
783
                      WIN_PROTO_DIR=`cygpath --windows $PROTO_DIR`

    
   
784
                      WIN_JAVA_DIR=`cygpath --windows $JAVA_DIR`

    
   
785
                    fi

    
   
786
                    mkdir -p $JAVA_DIR 2> /dev/null

    
   
787
                    for PROTO_FILE in `ls $PROTO_DIR/*.proto 2> /dev/null`

    
   
788
                    do

    
   
789
                        if [ "$IS_WIN" = "true" ]; then

    
   
790
                          protoc -I$WIN_PROTO_DIR --java_out=$WIN_JAVA_DIR $PROTO_FILE

    
   
791
                        else

    
   
792
                          protoc -I$PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE

    
   
793
                        fi

    
   
794
                    done

    
   
795
                </echo>

    
   
796
                <exec executable="sh" dir="${basedir}" failonerror="true">

    
   
797
                  <arg line="target/compile-proto.sh"/>

    
   
798
                </exec>

    
   
799
              </target>

    
   
800
            </configuration>

    
   
801
          </execution>

    
   
802
          <execution>
768
            <id>arc-setup</id>
803
            <id>arc-setup</id>
769
            <phase>initialize</phase>
804
            <phase>initialize</phase>
770
            <configuration>
805
            <configuration>
771
              <tasks if="arc">
806
              <tasks if="arc">
772
                <get dest="${project.build.directory}/arc-jira.tar.gz"
807
                <get dest="${project.build.directory}/arc-jira.tar.gz"
[+20] [20] 1491 lines
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
Revision 69434f7 New Change
 
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
Revision ae76204 New Change
 
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
Revision 9df4c10 New Change
 
src/main/java/org/apache/hadoop/hbase/HConstants.java
Revision 8888347 New Change
 
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
Revision cbfa489 New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
Revision 0db2760 New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
Revision 2916d68 New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
Revision fd97830 New Change
 
src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
Revision f1f06b0 New Change
 
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
Revision d47ef10 New Change
 
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Revision cd1755f New Change
 
src/main/java/org/apache/hadoop/hbase/master/MXBean.java
Revision 7f44dc2 New Change
 
src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java
Revision 45b8fe7 New Change
 
src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java
Revision be63838 New Change
 
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
Revision cbd55f7 New Change
 
src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java
New File
 
src/main/java/org/apache/hadoop/hbase/protobuf/PBHelper.java
New File
 
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Revision e0af8fb New Change
 
src/main/proto/MasterRegionProtocol.proto
New File
 
src/main/proto/hbase.proto
New File
 
src/main/resources/hbase-webapps/master/table.jsp
Revision 811df46 New Change
 
src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
Revision 6af9188 New Change
 
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
Revision 368a0e5 New Change
 
src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
Revision f2f8ee3 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
Revision 841649a New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java
Revision 379f70c New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
Revision e99d251 New Change
 
  1. pom.xml: Loading...
  2. src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon: Loading...
  3. src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon: Loading...
  4. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/HConstants.java: Loading...
  6. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java: Loading...
  7. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java: Loading...
  8. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java: Loading...
  9. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java: Loading...
  10. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java: Loading...
  11. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java: Loading...
  12. src/main/java/org/apache/hadoop/hbase/master/HMaster.java: Loading...
  13. src/main/java/org/apache/hadoop/hbase/master/MXBean.java: Loading...
  14. src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java: Loading...
  15. src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java: Loading...
  16. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: Loading...
  17. src/main/java/org/apache/hadoop/hbase/protobuf/MasterRegionInterface.java: Loading...
  18. src/main/java/org/apache/hadoop/hbase/protobuf/PBHelper.java: Loading...
  19. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: Loading...
  20. src/main/proto/MasterRegionProtocol.proto: Loading...
  21. src/main/proto/hbase.proto: Loading...
  22. src/main/resources/hbase-webapps/master/table.jsp: Loading...
  23. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java: Loading...
  24. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java: Loading...
  25. src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java: Loading...
  26. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java: Loading...
  27. src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java: Loading...
  28. src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java: Loading...