Review Board 1.7.22


Flume-1026: Document thread safety expectations of interfaces

Review Request #4400 - Created March 19, 2012 and submitted

Juhani Connolly
trunk
Flume-1026
Reviewers
Flume
flume-git
I went over the basic interfaces and added some javadoc for developers of new components.

I am pretty concerned about the fact that pretty much  everything is not thread safe because off the lack of guarantees provided by some of the interfaces(Configurable in particular).

A lot of existing components assume thread safety(which is somewhat given by isolation of process() type methods to a single runner thread). Should we be fixing these components, or making some more guarantees about when and how configuration calls should  be called(e.g. only callable on a stopped component?)
Doc only patch
Review request changed
Updated (March 22, 2012, 4 a.m.)
Added in Mike's wording suggestions.

Will: yeah, I think that configuration is at the center of the whole threading issue and we need to address that before we come around to individual components.
Posted (March 22, 2012, 6:21 a.m.)
+1 from me, thanks for writing this up and we will need to resolve this pretty soon
Ship it!
Posted (March 22, 2012, 6:39 a.m.)
+1