Review Board 1.7.22


QPID-3015: object creation and deletion via management

Review Request #436 - Created Feb. 18, 2011 and submitted

Gordon Sim
Reviewers
aconway, kgiusti, tross
qpid
* separated out common core for create/delete and bind operations from SessionAdapter (leave SessionAdapter for protocol specific details)
* added create/delete methods on broker to management schema and implemented those
* minor cleanup to Queue for deletion
* use thread local variable to ensure that the connection on which the management method is received can be retrieved when processing the method
Automated test added that exercises creation and deletion of queue, exchange and binding.
Tested acl manually - automated test pending
Ship it!
Posted (Feb. 22, 2011, 7:23 a.m.)
Nice refactor. I had notes in my cluster prototype code to do something like that, you saved me the trouble.
Ship it!
Posted (Feb. 22, 2011, 8:46 a.m.)

   

  
[nit] comment mismatch in prototype arglist: change /*strict*/ --> /*lenient*/
  1. Oops! Will fix!
Throw?
  1. Oops!! Will fix that too!
the "over-engineering" side of my brain says we'd want to reset the context pointer after the message is done processing.  Future proof any change that may reference a stale pointer due to not correctly setting the right context.  a nit.
  1. Yes, good point. I'll change that also.