Review Board 1.7.22


gadgets.selection.getSelection() does not return current selection on initial loading of gadget

Review Request #4310 - Created March 13, 2012 and submitted

Dan Dumont
SHINDIG-1727
Reviewers
shindig
shindig
Updated sample gadgets.
Added a dummy listener to the selection queue so that a gadget will always watch selection.
Selection registration now returns the current selection so that gadgets can prime their selection cache.
Updated and ran unit tests.
Updated sample gadgets, ran sample gadgets in the sample container.
Review request changed
Updated (March 13, 2012, 6:36 p.m.)
Changed tabs to spaces.
Posted (March 13, 2012, 8:28 p.m.)
LGTM, just the one question inline.
Before when this wasn't being returned, what did that affect?  Did that only mean the selection wasn't available in the callback to the register rpc call?
  1. I added the callback and the return so that initial selection would be published to the gadget without calling a selection changed listener (cause it didn't change, the gadget just didn't have it yet).
Ship it!
Posted (March 13, 2012, 8:56 p.m.)
LGTM echo Stanton's question
Ship it!
Posted (March 14, 2012, 2:03 p.m.)
LGTM
Ship it!
Posted (March 14, 2012, 2:07 p.m.)
Committed r1300552