Review Board 1.7.22


HBASE-5528 Change retrying splitting log forever if throws IOException to numbered times, and abort master when retries exhausted

Review Request #4194 - Created March 6, 2012 and updated

shen chunhui
trunk
Reviewers
hbase
hbase
In current log-splitting retry logic, it will retry forever if throws IOException, I think we'd better change it to numbered times, and abort master when retries exhausted.

 
Review request changed
Updated (March 7, 2012, 2:14 a.m.)
  • We will retry splitting log if failed in splitLogAfterStartup when master starts.
    However, there is no retry for failed splitting log in the process of ServerShutdownHandler.
    
    Also, if we finally failed to split log, we should abort master even if filesystem is ok to prevent data loss.
    

    In current log-splitting retry logic, it will retry forever if throws IOException, I think we'd better change it to numbered times, and abort master when retries exhausted.
  • changed from HBASE-5528 Retry splitting log if failed in the process of ServerShutdownHandler, and abort master when retries exhausted to HBASE-5528 Change retrying splitting log forever if throws IOException to numbered times, and abort master when retries exhausted
Remove log-splitting retry in ServerShutdownHandler.
Posted (March 7, 2012, 4:16 p.m.)
diff2 looks ok to me.