Review Board 1.7.22


HBASE 5444: First draft of HMasterRegionInterface Compatibility

Review Request #4149 - Created March 2, 2012 and updated

Gregory Chanan
HBASE-5444
Reviewers
hbase
hbase-git
Protobuf work for HMasterRegionInterface.

No need to comment on the pom.xml changes: I just copied those from HBASE-5443 (https://reviews.apache.org/r/4054/).
mvn -DskipTests package successful and files generated successfully

Diff revision 2 (Latest)

1 2
1 2

  1. pom.xml: Loading...
  2. src/main/proto/HMasterRegionProtocol.proto: Loading...
  3. src/main/proto/hbase.proto: Loading...
pom.xml
Revision 0f0aa9a New Change
[20] 733 lines
[+20]
734
      <plugin>
734
      <plugin>
735
        <artifactId>maven-antrun-plugin</artifactId>
735
        <artifactId>maven-antrun-plugin</artifactId>
736
        <version>1.6</version>
736
        <version>1.6</version>
737
        <executions>
737
        <executions>
738
          <execution>
738
          <execution>

    
   
739
            <id>compile-proto</id>

    
   
740
            <phase>generate-sources</phase>

    
   
741
            <goals>

    
   
742
              <goal>run</goal>

    
   
743
            </goals>

    
   
744
            <configuration>

    
   
745
              <target>

    
   
746
                <echo file="target/compile-proto.sh">

    
   
747
                    PROTO_DIR=src/main/proto

    
   
748
                    JAVA_DIR=target/generated-sources/java

    
   
749
                    which cygpath 2> /dev/null

    
   
750
                    if [ $? = 1 ]; then

    
   
751
                      IS_WIN=false

    
   
752
                    else

    
   
753
                      IS_WIN=true

    
   
754
                      WIN_PROTO_DIR=`cygpath --windows $PROTO_DIR`

    
   
755
                      WIN_JAVA_DIR=`cygpath --windows $JAVA_DIR`

    
   
756
                    fi

    
   
757
                    mkdir -p $JAVA_DIR 2> /dev/null

    
   
758
                    for PROTO_FILE in `ls $PROTO_DIR/*.proto 2> /dev/null`

    
   
759
                    do

    
   
760
                        if [ "$IS_WIN" = "true" ]; then

    
   
761
                          protoc -I$WIN_PROTO_DIR --java_out=$WIN_JAVA_DIR $PROTO_FILE

    
   
762
                        else

    
   
763
                          protoc -I$PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE

    
   
764
                        fi

    
   
765
                    done

    
   
766
                </echo>

    
   
767
                <exec executable="sh" dir="${basedir}" failonerror="true">

    
   
768
                  <arg line="target/compile-proto.sh"/>

    
   
769
                </exec>

    
   
770
              </target>

    
   
771
            </configuration>

    
   
772
          </execution>

    
   
773
          <execution>
739
            <id>arc-setup</id>
774
            <id>arc-setup</id>
740
            <phase>initialize</phase>
775
            <phase>initialize</phase>
741
            <configuration>
776
            <configuration>
742
              <tasks if="arc">
777
              <tasks if="arc">
743
                <get dest="${project.build.directory}/arc-jira.tar.gz"
778
                <get dest="${project.build.directory}/arc-jira.tar.gz"
[+20] [20] 1408 lines
src/main/proto/HMasterRegionProtocol.proto
New File
 
src/main/proto/hbase.proto
New File
 
  1. pom.xml: Loading...
  2. src/main/proto/HMasterRegionProtocol.proto: Loading...
  3. src/main/proto/hbase.proto: Loading...