Remove throwing UnsupportedOperationException with call to BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl
Review Request #4135 - Created March 1, 2012 and submitted
Simplify the SecurityToken.getActiveUrl implementation and definition. If not set simply return null should be suffice.
Updated unit test and run apps in common container
Posted (March 2, 2012, 12:52 p.m.)
Hi Henry, You should also remove the logic in org.apache.shindig.auth.BlobCrypterSecurityToken.fromToken(SecurityToken) where we eat the UnsupportedOperationException when calling getActiveUrl(). I'm also looking at org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator.checkGadgetCanRender(SecurityToken, OAuthArguments, OAuthResponseParams) and it seems like a value of "null" here is going to throw other exceptions when create a Uri.parse. I'm wondering if we can handle "null" more gracefully here... although we really weren't handling UnsupportedOperationException gracefully here either. Do you know why the exception was being thrown in the first place? Looking at the rest of the APIs in SecurityToken that one strikes me as odd.
Review request changed
Updated (June 26, 2012, 6:04 p.m.)
- changed from pending to submitted