Review Board 1.7.22

Fix broken support for 'transport' connection option

Review Request #4083 - Created Feb. 28, 2012 and submitted

Gordon Sim
aconway, kgiusti, mick
Previous unification of URL support broke the ability to supply the 'transport' (e.g. tcp, rdma, ssl etc) on a connection. This can still be supplied in the URL itself if the 0-10 URL format is used but the regression should be fixed.

The change in this patch adds a method to the Url class to parse a string without populating any resulting addresses with TCP as the default protocol if none is specified. This allows the protocol in the Address to indicate what was explicitly provided and lets the decision on defaults be taken elsewhere (in this case in the underlying client API). 
New case added to sssl tests that uses a mixture of url and connection-option. Make check passes. 
Review request changed
Updated (Feb. 28, 2012, 3:51 p.m.)
Changed to use default protocol passed in, as suggested by Alan.
Ship it!
Posted (Feb. 29, 2012, 3:59 p.m.)


Ship it!
Posted (March 1, 2012, 1:35 p.m.)
makes sense to me -- that defaulting decision definitely belongs at higher level.