Review Board 1.7.22


Cleanup open view APIs

Review Request #4077 - Created Feb. 28, 2012 and submitted

Ryan Baxter
SHINDIG-1712
Reviewers
shindig
ddumont, hsaputra, ibelakov
shindig
1. Recent changes to how RPC handlers are handled broke the RPC handler functions. Changes in the context in which the functions are run changed the value of this. 
2. Timing issues in sample gadget caused javascript errors when closing dialogs. 
3. When closing a dialog without pressing cancel or ok caused osapi errors because there was no media item to update. 
4. Use of console.log instead of using gadgets.log in sample gadget 
5. Always pass the relative element whenever the gadgets.views.open* APIs are called. 
6. Pass the gadget metadata to createElementForEmbeddedExperience when the EE data model has a gadget in it.
Testing in various containers
Review request changed
Updated (June 26, 2012, 6:05 p.m.)
  • changed from pending to submitted