Review Board 1.7.22


HBase-5619, the ProtoBuff HRegionProtocol.

Review Request #4054 - Created Feb. 27, 2012 and submitted

Jimmy Xiang
HBASE-5619
Reviewers
hbase
hbase-git
This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443

Please review.  I'd like to move ahead after we get to some agreement.

 

Diff revision 3

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

1 2 3 4 5 6
1 2 3 4 5 6

  1. pom.xml: Loading...
  2. src/main/proto/RegionAdmin.proto: Loading...
  3. src/main/proto/RegionClient.proto: Loading...
  4. src/main/proto/hbase.proto: Loading...
pom.xml
Revision 10b13ef New Change
[20] 762 lines
[+20]
763
      <plugin>
763
      <plugin>
764
        <artifactId>maven-antrun-plugin</artifactId>
764
        <artifactId>maven-antrun-plugin</artifactId>
765
        <version>1.6</version>
765
        <version>1.6</version>
766
        <executions>
766
        <executions>
767
          <execution>
767
          <execution>

    
   
768
            <id>compile-proto</id>

    
   
769
            <phase>generate-sources</phase>

    
   
770
            <goals>

    
   
771
              <goal>run</goal>

    
   
772
            </goals>

    
   
773
            <configuration>

    
   
774
              <target>

    
   
775
                <echo file="target/compile-proto.sh">

    
   
776
                    UNIX_PROTO_DIR=src/main/proto

    
   
777
                    JAVA_DIR=target/generated-sources/java

    
   
778
                    mkdir -p $JAVA_DIR 2> /dev/null

    
   
779
                    which cygpath 2> /dev/null

    
   
780
                    if [ $? = 1 ]; then

    
   
781
                      PROTO_DIR=$UNIX_PROTO_DIR

    
   
782
                    else

    
   
783
                      PROTO_DIR=`cygpath --windows $UNIX_PROTO_DIR`

    
   
784
                      JAVA_DIR=`cygpath --windows $JAVA_DIR`

    
   
785
                    fi

    
   
786
                    for PROTO_FILE in `ls $UNIX_PROTO_DIR/*.proto 2> /dev/null`

    
   
787
                    do

    
   
788
                      protoc -I$PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE

    
   
789
                    done

    
   
790
                </echo>

    
   
791
                <exec executable="sh" dir="${basedir}" failonerror="true">

    
   
792
                  <arg line="target/compile-proto.sh"/>

    
   
793
                </exec>

    
   
794
              </target>

    
   
795
            </configuration>

    
   
796
          </execution>

    
   
797
          <execution>
768
            <id>arc-setup</id>
798
            <id>arc-setup</id>
769
            <phase>initialize</phase>
799
            <phase>initialize</phase>
770
            <configuration>
800
            <configuration>
771
              <tasks if="arc">
801
              <tasks if="arc">
772
                <get dest="${project.build.directory}/arc-jira.tar.gz"
802
                <get dest="${project.build.directory}/arc-jira.tar.gz"
[+20] [20] 1491 lines
src/main/proto/RegionAdmin.proto
New File
 
src/main/proto/RegionClient.proto
New File
 
src/main/proto/hbase.proto
New File
 
  1. pom.xml: Loading...
  2. src/main/proto/RegionAdmin.proto: Loading...
  3. src/main/proto/RegionClient.proto: Loading...
  4. src/main/proto/hbase.proto: Loading...