Review Board 1.7.22


java.lang.IllegalStateException: CoordChangeXCommand already used is thrown while executing interrupt commands java.lang.IllegalStateException: CoordChangeXCommand already used.

Review Request #4035 - Created Feb. 24, 2012 and submitted

Mohamed Battisha
OOZIE-684
Reviewers
oozie
oozie
While executing an interrupt driven commands it may be executed from the map on one thread and executed from the queue at a different thread 
This will cause the following exception to be thrown: 
java.lang.IllegalStateException: CoordChangeXCommand already used. 

- Avoiding throwing exception in case of interrupts and synchronizing the changes in [used] 
- Avoiding executing interrupt in case of commands that doesn't need locks
- Changing the debug message for execute interrupt to explicitly mentioning it is an interrupt command

 

Diff revision 4

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

1 2 3 4 5 6
1 2 3 4 5 6

  1. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java: Loading...
Content-Type: text/html; charset=utf-8
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
Revision 1293381 New Change
Diff currently unavailable.
Error: The file '/repos/asf/oozie/http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java' (r1293381) could not be found in the repository: '/repos/asf/!svn/bc/1293381/oozie/http:/svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java' path not found
Details
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/views.py", line 117, in view_diff
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 344, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 137, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 136, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 141, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 126, in get_original_file
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 192, in get_file
    large_data=True)[0]
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 191, in <lambda>
    request)],
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/models.py", line 287, in _get_file_uncached
    data = self.get_scmtool().get_file(path, revision)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/svn.py", line 191, in get_file
    return self._do_on_path(get_file_data, path, revision)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/scmtools/svn.py", line 165, in _do_on_path
    raise FileNotFoundError(path, revision, detail=str(e))
FileNotFoundError: The file '/repos/asf/oozie/http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java' (r1293381) could not be found in the repository: '/repos/asf/!svn/bc/1293381/oozie/http:/svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java' path not found
  1. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java: Loading...