Review Board 1.7.22

Enable CheckStyle plugin during maven build

Review Request #3959 - Created Feb. 19, 2012 and submitted

Stanton Sievers
CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. 

There are some mismatches between the headers in some of the files.  I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match.  This is one of the "obvious style problems" I mentioned above that I will fix.

The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files.  If this is worth fixing, I can do that as well.
Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.
Review request changed
Updated (Feb. 20, 2012, 2:14 p.m.)
Ran through one more time and tweaked some things.  Added some more information where appropriate.

I'll go ahead and deliver this by EOD tomorrow if no one has any other comments.
Ship it!
Posted (Feb. 21, 2012, 2:24 p.m.)
LGTM should help alot.
Ship it!
Posted (Feb. 21, 2012, 9:46 p.m.)
Committed revision 1292048