Review Board 1.7.22


Incorporated Francis comments

Review Request #3945 - Created Feb. 17, 2012 and updated

Vikram Dixit Kumaraswamy
HCATALOG-239
Reviewers
francisliu, sushanth
hcatalog
Incorporated Francis' comments.

 

Diff revision 2

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

1 2 3 4
1 2 3 4

  1. trunk/src/java/org/apache/hcatalog/common/ErrorType.java: Loading...
  2. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java: Loading...
  3. trunk/src/java/org/apache/hcatalog/data/DataType.java: Loading...
  4. trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java: Loading...
  5. trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java: Loading...
  6. trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java: Loading...
  7. trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java: Loading...
  8. trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java: Loading...
  9. trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java: Loading...
  10. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java: Loading...
  11. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java: Loading...
  12. trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java: Loading...
  13. trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java: Loading...
  14. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java: Loading...
  15. trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java: Loading...
  16. trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java: Loading...
  17. trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java: Loading...
  18. trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java: Loading...
  19. trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java: Loading...
  20. trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java: Loading...
  21. trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java: Loading...
  22. trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java: Loading...
  23. trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java: Loading...
  24. trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java: Loading...
trunk/src/java/org/apache/hcatalog/common/ErrorType.java
Revision 1292521 New Change
[20] 23 lines
[+20]
24

    
   
24

   
25
    /* HCat Input Format related errors 1000 - 1999 */
25
    /* HCat Input Format related errors 1000 - 1999 */
26
    ERROR_DB_INIT                       (1000, "Error initializing database session"),
26
    ERROR_DB_INIT                       (1000, "Error initializing database session"),
27
    ERROR_EXCEED_MAXPART                (1001, "Query result exceeded maximum number of partitions allowed"),
27
    ERROR_EXCEED_MAXPART                (1001, "Query result exceeded maximum number of partitions allowed"),
28

    
   
28

   

    
   
29
    ERROR_SET_INPUT                    (1002, "Error setting input information"),
29

    
   
30

   
30
    /* HCat Output Format related errors 2000 - 2999 */
31
    /* HCat Output Format related errors 2000 - 2999 */
31
    ERROR_INVALID_TABLE                 (2000, "Table specified does not exist"),
32
    ERROR_INVALID_TABLE                 (2000, "Table specified does not exist"),
32
    ERROR_SET_OUTPUT                    (2001, "Error setting output information"),
33
    ERROR_SET_OUTPUT                    (2001, "Error setting output information"),
33
    ERROR_DUPLICATE_PARTITION           (2002, "Partition already present with given partition key values"),
34
    ERROR_DUPLICATE_PARTITION           (2002, "Partition already present with given partition key values"),
[+20] [20] 101 lines
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/data/DataType.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java
Revision 1292521 New Change
 
trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
Revision 1292521 New Change
 
trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
Revision 1292521 New Change
 
trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
Revision 1292521 New Change
 
trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java
Revision 1292521 New Change
 
trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java
Revision 1292521 New Change
 
  1. trunk/src/java/org/apache/hcatalog/common/ErrorType.java: Loading...
  2. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java: Loading...
  3. trunk/src/java/org/apache/hcatalog/data/DataType.java: Loading...
  4. trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java: Loading...
  5. trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java: Loading...
  6. trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java: Loading...
  7. trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java: Loading...
  8. trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java: Loading...
  9. trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java: Loading...
  10. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java: Loading...
  11. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java: Loading...
  12. trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java: Loading...
  13. trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java: Loading...
  14. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java: Loading...
  15. trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java: Loading...
  16. trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java: Loading...
  17. trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java: Loading...
  18. trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java: Loading...
  19. trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java: Loading...
  20. trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java: Loading...
  21. trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java: Loading...
  22. trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java: Loading...
  23. trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java: Loading...
  24. trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java: Loading...