Review Board 1.7.22


Incorporated Francis comments

Review Request #3945 - Created Feb. 17, 2012 and updated

Vikram Dixit Kumaraswamy
HCATALOG-239
Reviewers
francisliu, sushanth
hcatalog
Incorporated Francis' comments.

 
Review request changed
Updated (Feb. 24, 2012, 9 p.m.)
Incorporated Francis'/Sushanth's comments.
Posted (Feb. 24, 2012, 10:59 p.m.)

   

  
Yeah sounds better, in general throwing Exception is not good since you're forcing the user to capture RuntimeException, etc as well.
Posted (Feb. 24, 2012, 11:09 p.m.)

   

  
Daniel and I already had this discussion about getSplits() passing conf, see HCATALOG-226 where we reference jobclient source code proving that it does get passed downstream. Apart from some storageHandlers needing it HCATALOG-247, you are breaking mapreduce behavior.
Ship it!
Posted (Feb. 25, 2012, 1:01 a.m.)
There are some issues that need to be addressed, but can be addressed later to unblock testing.