Review Board 1.7.22


rpc does not support communicating with gadget created on an dom node in existing iframe

Review Request #3908 - Created Feb. 15, 2012 and updated

Yao Zhang
SHINDIG-1704
Reviewers
shindig
ddumont, hsaputra, lixu, ssievers
shindig
When you try to render a gadget to a dom node inside an existing iframe, rpc does not work as the code is using document.getElementById to get the domnode

 
Total:
6
Open:
6
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
Nit on whitespace and use of tabs instead of spaces. Stanton Sievers June 29, 2012, 10:56 a.m. Open
Nite on trailing whitespace Stanton Sievers June 29, 2012, 10:56 a.m. Open
Nit on tabs instead of spaces Stanton Sievers June 29, 2012, 10:56 a.m. Open
Nit on whitespace Stanton Sievers June 29, 2012, 10:56 a.m. Open
Nit on tabs instead of spaces Stanton Sievers June 29, 2012, 10:56 a.m. Open
Nit on tabs instead of spaces. Stanton Sievers June 29, 2012, 10:56 a.m. Open
Review request changed
Updated (March 19, 2012, 7:38 a.m.)
Posted (June 29, 2012, 10:56 a.m.)
Can you look at adding some JUnits around this functionality?  I'm always concerned about breaking RPC, since it is at the core of basically everything that happens client-side.  

The rest is mostly comments on style.  
Nit on whitespace and use of tabs instead of spaces.
Nite on trailing whitespace
Nit on tabs instead of spaces
Nit on whitespace
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js (Diff revision 3)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
Nit on tabs instead of spaces
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js (Diff revision 3)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
Nit on tabs instead of spaces.
Posted (June 29, 2012, 5:48 p.m.)
To make it easier to review, please format the patch following the Apache Shindig recommended JavaScript formatting: https://cwiki.apache.org/SHINDIGxSITE/javascript-style.html