Review Board 1.7.22


Cleanup NOTICE and LICENSE files

Review Request #3887 - Created Feb. 13, 2012 and submitted

Ate Douma
SHINDIG-1689
Reviewers
shindig
shindig
This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E

The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J

 
Review request changed
Updated (March 15, 2012, 1:10 p.m.)
Updated patch with only trailing whitespaces removed
Posted (March 21, 2012, 10:09 p.m.)
Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
  1. The appended-resources directory is used by the maven-remote-resources-plugin in combination with the (default configured) apache-jar-resource-bundle.
    That resource bundle provides the standard ASL 2.0 LICENSE and basic NOTICE file (as velocity template).
    The plugin will look for matching resource *fragments* in the appended-resources folder and if found append them to the base template from the resource bundle.
    Effectively, this largely reduces the amount and size of to be provided LICENSE and NOTICE file per artifact/module, as only appendable fragments need to be provided, if needed at all.
    
    So the appended-resources directory is *not* automatically generated by my build but needed and used to generate final and complete LICENSE and NOTICE files. 
  2. Just committed the patch but looks like you just delete the content of features/NOTICE and other files instead of deleting the files themselves. Any reason why we need to have those empty files?
  3. Weird. When I applied the patch myself using Eclipse to validate it, it actually did remove those empty files. Seems to depend on how you apply it or what tool you use.
    It definitely is the intend to remove those empty files, so I suggest to now manually delete then.
    Sorry for the inconvenience.
  4. Will do thanks