Review Board 1.7.22


new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost

Review Request #3768 - Created Feb. 7, 2012 and submitted

Dan Dumont
SHINDIG-1695
Reviewers
shindig
rbaxter, ssievers
shindig
With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. 

It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

 

Diff revision 3

This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.

1 2 3 4 5 6 7
1 2 3 4 5 6 7

  1. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js: Loading...
  2. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml: Loading...
  3. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt: Loading...
  4. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js: Loading...
  5. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js: Loading...
  6. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml: Loading...
  7. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js: Loading...
  8. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js: Loading...
  9. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java: Loading...
  10. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java: Loading...
  11. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java: Loading...
  12. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java: Loading...
  13. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java: Loading...
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
Revision 1241308 New Change
[20] 137 lines
[+20]
138
"gadgets.admin.enableFeatureAdministration" : "false",
138
"gadgets.admin.enableFeatureAdministration" : "false",
139

    
   
139

   
140
// Enables whitelist checks
140
// Enables whitelist checks
141
"gadgets.admin.enableGadgetWhitelist" : "false",
141
"gadgets.admin.enableGadgetWhitelist" : "false",
142

    
   
142

   

    
   
143
// Max post size for posts through the makeRequest proxy.

    
   
144
"gadgets.jsonProxyUrl.maxPostSize" : 5242880, // 5 megs

    
   
145

   
143
// This config data will be passed down to javascript. Please
146
// This config data will be passed down to javascript. Please
144
// configure your object using the feature name rather than
147
// configure your object using the feature name rather than
145
// the javascript name.
148
// the javascript name.
146

    
   
149

   
147
// Only configuration for required features will be used.
150
// Only configuration for required features will be used.
[+20] [20] 169 lines
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml
New File
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
New File
 
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js
New File
 
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
Revision 1241308 New Change
 
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java
Revision 1241308 New Change
 
  1. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js: Loading...
  2. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml: Loading...
  3. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt: Loading...
  4. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js: Loading...
  5. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js: Loading...
  6. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml: Loading...
  7. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js: Loading...
  8. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js: Loading...
  9. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java: Loading...
  10. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java: Loading...
  11. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java: Loading...
  12. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java: Loading...
  13. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java: Loading...