Review Board 1.7.22


ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop security configuration override

Review Request #3631 - Created Jan. 25, 2012 and updated

Eugene Koontz
trunk
ZOOKEEPER-1373
Reviewers
zookeeper
zookeeper-git
ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop security configuration override

Fix is to allow system property to designate the JAAS configuration section that the zookeeper client will use.
"ant test" java tests pass.
Review request changed
Updated (Jan. 26, 2012, 12:30 a.m.)
Address Ted and Thomas' reviews.
Posted (Jan. 26, 2012, 6:18 p.m.)
Tested patch with Hadoop client and CLI and works as expected. Only remaining question I have is WRT added comments in zoo_sample.cfg
conf/zoo_sample.cfg (Diff revision 3)
 
 
What is the purpose of adding this to the server config?
  1. Thomas, thanks for testing, and you are right - it doesn't belong here.
    
    It should probably be here:
    
    https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL
    
    I'll edit that today (feel free to do so also, and would be curious to hear your comments about this wiki entry, was it helpful for you?)
  2. Hi Eugene, I found your other page more useful as it covers the users perspective: https://github.com/ekoontz/zookeeper/wiki
    
    This should become part of the ZooKeeper documentation.
    
Posted (Jan. 27, 2012, 7:21 p.m.)
Eugene, can you complete the patch for this issue? Documentation could be taken up separately.