HIVE-1931: Improve the implementation of the METASTORE_CACHE_PINOBJTYPES config
Review Request #360 - Created Jan. 26, 2011 and updated
Review request for HIVE-1931
Hi Mac, thanks for following up on this. I have a couple comments, mainly focused on the need to mention hive.metastore.cache.pinobjtypes by name in the log statements.
I think this LOG message should be moved up a line so that it prints regardless of whether or not objTypes is null, and the message should also mention hive.metastore.cache.pinobjtypes by name, e.g: Setting MetaStore object pin classes with hive.metastore.cache.pinobjtypes="Table,StorageDescriptor,..."
Maybe replace the for loop with StringUtils.join(PINCLASSMAP.keySet(), " ") ?
Please change this to "PersistenceManagerFactory returned null DataStoreCache object. Unable to initialize object pin types defined by hive.metastore.cache.pinobjtypes"