Review Board 1.7.22


BOOKKEEPER-112: Bookie Recovery on an open ledger will cause LedgerHandle#close on that ledger to fail

Review Request #3472 - Created Jan. 12, 2012 and updated

Sijie Guo
BOOKKEEPER-112
Reviewers
bookkeeper
bookkeeper-git
Bookie recovery updates the ledger metadata in zookeeper. LedgerHandle will not get notified of this update, so it will try to write out its own ledger metadata, only to fail with KeeperException.BadVersion. This effectively fences all write operations on the LedgerHandle (close and addEntry). close will fail for obvious reasons. addEntry will fail once it gets to the failed bookie in the schedule, tries to write, fails, selects a new bookie and tries to update ledger metadata.

Update Line 605, testSyncBookieRecoveryToRandomBookiesCheckForDupes(), when done
Also, uncomment addEntry in TestFencing#testFencingInteractionWithBookieRecovery()

 
Review request changed
Updated (March 30, 2012, 12:12 p.m.)
adding one line to release permit when submit callback in PendingReadOp. similar as BOOKKEEPER-186.