Review Board 1.7.22


WAVE-298: Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

Review Request #2932 - Created Nov. 25, 2011 and submitted

Antonio Bello
WAVE-298
Reviewers
wave
wave
This patch solves the problem in my case. 

I'm running ubuntu x64, and experienced the same problem. 

What I did is simply change the parameter type passed to the thenReturn() method: 
* convert StringTokenizer to Enumeration<String> in ActiveApiServletTest 
* replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest 
ant test runs with no errors on ubuntu x64 10.04
Review request changed
Updated (Nov. 25, 2011, 6:23 p.m.)
Posted (Nov. 26, 2011, 10:11 a.m.)

   

  
The line is too long - longer than 100 chars which is the standard for WIAB.
Line is too long.
Seems like the <code></code> tags here are not needed,{@link} already formats it.
No need to specify that methods solve issue.
Probably it would be better just to remove @param and @return since they add no details.
How about returning the Collections.EmptyMap() here?
I mean:
 Map<String, String[]> emptyMap = Collections.emptyMap();
    when(req.getParameterMap()).thenReturn(emptyMap);
Ship it!
Posted (Nov. 26, 2011, 10:12 a.m.)
Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.
I will address the comments by myself and commit if it's OK with you.
  1. Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.
    Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.
    
    Antonio
  2. This is great, thanks!
  3. My pleasure :)
    I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one
  4. For getting the latest code you can use either the SVN repository or the Git mirror
    SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/
    Git mirror:  git://git.apache.org/wave.git
    If you feel ready to submit a patch - then just use this Review Board for this.
  5. Can you please close this review request?
  6. Ditto. Please close this review request?