Review Board 1.7.22


HBASE-4820 Distributed log splitting coding enhancement to make it easier to understand, no semantics change

Review Request #2895 - Created Nov. 21, 2011 and submitted

Jimmy Xiang
git://git.apache.org/hbase.git
HBASE-4820
Reviewers
hbase
jonathan, tlipcon
hbase-git
Distributed log splitting coding enhancement to make it easier to understand, no semantics change.
It is some issue raised during the code review in back porting this feature to CDH.
Ran unit tests. Non-flaky tests are green. Two client tests didn't pass, which are not related to this change.
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
Revision f7ef653 New Change
[20] 59 lines
[+20]
60
import org.apache.hadoop.hbase.client.Result;
60
import org.apache.hadoop.hbase.client.Result;
61
import org.apache.hadoop.hbase.executor.EventHandler.EventType;
61
import org.apache.hadoop.hbase.executor.EventHandler.EventType;
62
import org.apache.hadoop.hbase.executor.ExecutorService;
62
import org.apache.hadoop.hbase.executor.ExecutorService;
63
import org.apache.hadoop.hbase.executor.RegionTransitionData;
63
import org.apache.hadoop.hbase.executor.RegionTransitionData;
64
import org.apache.hadoop.hbase.ipc.ServerNotRunningYetException;
64
import org.apache.hadoop.hbase.ipc.ServerNotRunningYetException;
65
import org.apache.hadoop.hbase.master.AssignmentManager.RegionState;

   
66
import org.apache.hadoop.hbase.master.handler.ClosedRegionHandler;
65
import org.apache.hadoop.hbase.master.handler.ClosedRegionHandler;
67
import org.apache.hadoop.hbase.master.handler.DisableTableHandler;
66
import org.apache.hadoop.hbase.master.handler.DisableTableHandler;
68
import org.apache.hadoop.hbase.master.handler.EnableTableHandler;
67
import org.apache.hadoop.hbase.master.handler.EnableTableHandler;
69
import org.apache.hadoop.hbase.master.handler.OpenedRegionHandler;
68
import org.apache.hadoop.hbase.master.handler.OpenedRegionHandler;
70
import org.apache.hadoop.hbase.master.handler.ServerShutdownHandler;
69
import org.apache.hadoop.hbase.master.handler.ServerShutdownHandler;
[+20] [20] 1454 lines
[+20] [+] private boolean isDisabledorDisablingRegionInRIT(final HRegionInfo region) {
1525
  int setOfflineInZooKeeper(final RegionState state,
1524
  int setOfflineInZooKeeper(final RegionState state,
1526
      boolean hijack) {
1525
      boolean hijack) {
1527
    // In case of reassignment the current state in memory need not be
1526
    // In case of reassignment the current state in memory need not be
1528
    // OFFLINE. 
1527
    // OFFLINE. 
1529
    if (!hijack && !state.isClosed() && !state.isOffline()) {
1528
    if (!hijack && !state.isClosed() && !state.isOffline()) {
1530
      this.master.abort("Unexpected state trying to OFFLINE; " + state,
1529
      String msg = "Unexpected state trying to OFFLINE; " + state;
1531
          new IllegalStateException());
1530
      this.master.abort(msg, new IllegalStateException(msg));
1532
      return -1;
1531
      return -1;
1533
    }
1532
    }
1534
    boolean allowZNodeCreation = false;
1533
    boolean allowZNodeCreation = false;
1535
    // Under reassignment if the current state is PENDING_OPEN
1534
    // Under reassignment if the current state is PENDING_OPEN
1536
    // or OPENING then refresh the in-memory state to PENDING_OPEN. This is
1535
    // or OPENING then refresh the in-memory state to PENDING_OPEN. This is
[+20] [20] 1404 lines
src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
Revision b9a3a2c New Change
 
src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
Revision 7dd67e9 New Change
 
src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
Revision 1d329b0 New Change
 
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
Revision 21747b1 New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
Revision 51daa1f New Change
 
src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
Revision c8684ec New Change
 
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
Revision 84d76e8 New Change
 
  1. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java: Loading...
  2. src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java: Loading...
  3. src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java: Loading...
  4. src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java: Loading...
  5. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java: Loading...
  6. src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java: Loading...
  7. src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java: Loading...
  8. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java: Loading...