hbase-3939 Crossport HADOOP-1849 rpc fix
Review Request #2718 - Created Nov. 4, 2011 and updated
Versions of Gary suggestions
Just a couple of comments. Otherwise looks good to me.
We could eliminate the flag and use status instead. Are there plans for other bits being set in this? Otherwise, we always have length and error can be determined from Status. Or would removing this break asynchbase in other ways?
Don't think this is necessary? The super.readFields(in) should throw VersionMismatchException if the read version doesn't match our getVersion().
Probably better to use super.write(out) here. Same code, but future proof to changes.
Should be able to remove this now that Invocation implements VersionedWritable.
Should be able to remove this now that Invocation implements VersionedWritable. I didn't see any dependency on rpc version outside of the Invocation serialization.