Review Board 1.7.22


Media gadgets does not work on IE8

Review Request #2527 - Created Oct. 21, 2011 and submitted

Jason Chiang
SHINDIG-1648
Reviewers
shindig
ddumont, rbaxter
shindig
This patch fix the IE8 rendering issue on both Sample media items gadget and Sample media items with openGadget API gadget.
All changes are on the gadget code.
Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
Test done on the sample container testing with both Firefox and IE8 
Posted (Oct. 21, 2011, 5 p.m.)

   

  
pixel dimensions instead of percentage?
  1. right, set both the width and height to 100 pixel for the thumbnail image.
I would think you still want width:'100%' and height: '100%' here.

That json bag are the attributes you want set on a node...   so you'll want <img height="100%" width="100%"... > right?

Or did you mean to change this to pixel dimensions instead of percentage?
  1. see above
Ship it!
Posted (Oct. 21, 2011, 5:15 p.m.)
LGTM
Ship it!
Posted (Oct. 21, 2011, 9:17 p.m.)
 Committed revision 1187546.
There seems to be a bunch of duplicate code between the gadgets, maybe you should think about abstracting the comment code out so you dont have to make changes in 2 places.