Review Board 1.7.22

Ensure that we replay logs correctly.

Review Request #2524 - Created Oct. 21, 2011 and updated

Amitanand Aiyer
0.89, 0.92
amitanand, jgray, kannanm, karthik.ranga, lhofhansl, nspiegelberg, stack, tedyu
There is a data loss happening (for some of the column families) when we do the replay logs.

The bug seems to be from the fact that during replay-logs we only choose to replay
the logs from the maximumSequenceID across ALL the stores. This is wrong. If a
column family is ahead of others (because the crash happened before all the column
families were flushed), then we lose data for the column families that have not yet
caught up.

The correct logic for replay should begin the replay from the minimum across the
maximum in each store.
Initial patch. v1.

mvn test (running).
Review request changed
Updated (Oct. 21, 2011, 10:21 p.m.)
  • Initial patch. v1.
    mvn test (running).
    TBD: add a test case to repro the issue and make sure it fixes.

    Initial patch. v1.
    mvn test (running).
Ship it!
Posted (Oct. 21, 2011, 10:27 p.m.)
update test looks good! 
Ship it!
Posted (Oct. 21, 2011, 10:37 p.m.)
Thanks for the explanation Amit.