Review Board 1.7.22


HBase-4555: TestShell seems passed, but actually errors are seen in test output file

Review Request #2351 - Created Oct. 11, 2011 and updated

Mingjie Lai
trunk
HBase-4555
Reviewers
hbase
hbase-git
HBase shell unit cases are in ruby. Ruby unit test runner Test::Unit::AutoRunner.run only prints unit tests assertion failures to console by default. So it actually swallows all the assertion errors from ruby, and junit cannot notice any shell test failure. 

Fixed the test_runner.rb to chech the return value and throw a runtime exception, so that TestShell can get to know there is something wrong by test errors. 

Also fixed 7 previously existing failed test cases. 

In addition, after HBase-1730, there's no need to disable a table before altering a table. Changed the test cases accordingly. 
TestShell passed locally. 
Ship it!
Posted (Oct. 11, 2011, 11:50 p.m.)

   

  
  1. Mind adding this patch to JIRA so I can apply it Mingjie (You need to add it because you need to click the "Grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)" button since you wrote the patch.  Good stuff.