Review HCatalog-119 HBaseBulkOutputStorageDriver
Review Request #2152 - Created Oct. 3, 2011 and updated
bulk implementation of HBaseOutputStorageDriver
new tests added. existing tests passed.
Since you set the default to -1, should this be changed to revision == null || "-1".equals(revision)?
Since you extended HCatOutputStorageDriver, do you really need this?
Why not use HFileOutputFormat<ImmutableBytesWritable, KeyValue>?
Why spin off another job rather than using LoadIncrementalHFiles?
If that job is in the commitJob phase, are the Map/Reduce resource still allocated? If they are still allocated what happens if there are no slots left, does this job just hang?
Why not use HBaseBulkOutputFormat.setOutputPath (provided by FileOutputFormat)?
Since you have determinOSD, why not only have activeOSD and remove bulkOSD and directOSD?
You set bulkOSD or directOSD null, but you use both in setPartition, setSchema, setOutputPath. Wont these be null when those methods are called?