Review Board 1.7.22


HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

Review Request #2150 - Created Oct. 3, 2011 and updated

Todd Lipcon
HDFS-1623
HDFS-2301
Reviewers
hadoop-hdfs
tlipcon
hadoop-common
Uploading Suresh's patch to reviewboard (https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 29/Sep/11 00:56)

 
Review request changed
Updated (Oct. 6, 2011, 11:25 p.m.)
updating reviewboard patch to Suresh's new revision
Posted (Oct. 6, 2011, 11:37 p.m.)

   

  
perhaps should be abstract since it won't ever be instantiated?

these functions are meant only for the server side, right? Otherwise they should all take an authority, and look at configs prefixed/suffixed with that authority?

let me jump over to HDFS-2231 and try to review that first.. having a hard time following this.
  1. Class has private constructor. I prefer that to abstract class. For some reason, I included HAUtil in this patch causing lot of confusion. It belongs to 2231. So I am attaching a patch without HAUtil changes. Also I will address rest of your HAUtil comments in 2231.
    
!collection.isEmpty()
long line
strange formatting
so this patch now depends on HDFS-2231 (Conf changes for HA NN), right?