Review Board 1.7.22


review build script enhancement to include storage drivers submodule

Review Request #2062 - Created Sept. 27, 2011 and updated

Francis Liu
trunk
hcatalog-101
Reviewers
hcatalog
avandana, sushanth
hcatalog-git
Need to modularize addition of new storage drivers. Created a separate subdirectory for all storage drivers to be placed. Refactored out hcatalog common build classpath for sub-modules to use.

Sushanth, if you can just take a look and see if the general approach is ok. Since this affects the hcatalog build script.
unit tests of module and submodule pass.
Review request changed
Updated (Oct. 3, 2011, 1:27 p.m.)
update with javadoc comments and updated build script to new hcatalog package structure
Posted (Oct. 3, 2011, 8:57 p.m.)
Hey Francis, 

I applied this patch and ran the command:

ant package -Dforrest.home=<apache-forrest-home>

The build failed with the following errors. 


/Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/build.xml:600: The following error occurred while executing this line:
/Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/build.xml:406: The following error occurred while executing this line:
/Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/storage-drivers/build.xml:55: The following error occurred while executing this line:
/Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/storage-drivers/build.xml:28: The following error occurred while executing this line:
/Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/storage-drivers/hbase/build.xml:319: /Users/avandana/hcat-dev-wksp/apache-trunk/hcatalog/storage-drivers/hbase/lib does not exist.
  1. I see, this is a problem with git. You can't add empty directories into the repository.